Skip to content

Commit

Permalink
Merge intervals for WES in GATK GenomicsDBImport (#1777)
Browse files Browse the repository at this point in the history
<!--
# nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not
relevant).
These are the most common things requested on pull requests (PRs).

Remember that PRs should be made against the dev branch, unless you're
preparing a pipeline release.

Learn more about contributing:
[CONTRIBUTING.md](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md)
-->

## PR checklist

- [x] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add
tests!
- [ ] If you've added a new tool - have you followed the pipeline
conventions in the [contribution
docs](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/sarek _branch_ on the
[nf-core/test-datasets](https://github.com/nf-core/test-datasets)
repository.
- [x] Make sure your code lints (`nf-core pipelines lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker
--outdir <OUTDIR>`).
- [ ] Check for unexpected warnings in debug mode (`nextflow run .
-profile debug,test,docker --outdir <OUTDIR>`).
- [ ] Usage Documentation in `docs/usage.md` is updated.
- [ ] Output Documentation in `docs/output.md` is updated.
- [x] `CHANGELOG.md` is updated.
- [ ] `README.md` is updated (including new tool citations and
authors/contributors).

Running sarek with `--joint_germline` on WES samples with an intervals
file containing many thousands of targets causes GATK `GenomicsDBImport`
to create millions of files and run for several days without completing.
Adding the `--merge-intervals` option to that process fixes that. This
PR add the parameter conditional on the `--wes` pipeline parameter.

Closes #1776

---------

Co-authored-by: Thomas <[email protected]>
Co-authored-by: Friederike Hanssen <[email protected]>
  • Loading branch information
3 people authored Jan 27, 2025
1 parent 73cacd5 commit dfb2d15
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- [1767](https://github.com/nf-core/sarek/pull/1767) - Bump nf-schema version to 2.2.1
- [1777](https://github.com/nf-core/sarek/pull/1777) - Merge intervals for WES in GATK GenomicsDBImport

### Fixed

Expand Down
4 changes: 3 additions & 1 deletion conf/modules/joint_germline.config
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
process {

withName: 'GATK4_GENOMICSDBIMPORT' {
ext.args = { '--genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' }
ext.args = { params.wes ?
'--merge-input-intervals --genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' :
'--genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' }
ext.prefix = { "${meta.intervals_name}.joint" }
publishDir = [
enabled: false
Expand Down

0 comments on commit dfb2d15

Please sign in to comment.