Merge pull request #942 from KevinMenden/better-log-output

nf-core · Mar 23, 2021 · 3dd6427 · 3dd6427
2 parents c51f8f0 + 655a1cf
commit 3dd6427
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,8 +2,8 @@
 
 ## v1.13.2dev
 
-### Tools code
-
+* Added better logging message if a user doesn't specificy the directory correctly with `nf-core modules` commands [[#942](https://github.com/nf-core/tools/pull/942)]
+* Fixed parameter validation bug caused by JSONObject [[#937](https://github.com/nf-core/tools/issues/937)]
 * Split the `create-lint-wf` tests up into separate steps in GitHub Actions to make the CI results easier to read
 * Added automated PR comments to the Markdownlint and Python Black lint CI tests to explain failures
 

diff --git a/nf_core/modules/create.py b/nf_core/modules/create.py
@@ -251,7 +251,10 @@ def get_repo_type(self, directory):
         elif os.path.exists(os.path.join(directory, "software")):
             return "modules"
         else:
-            raise UserWarning(f"Could not determine repository type: '{directory}'")
+            raise UserWarning(
+                f"This directory does not look like a clone of nf-core/modules or an nf-core pipeline: '{directory}'"
+                " Please point to a valid directory."
+            )
 
     def get_module_dirs(self):
         """Given a directory and a tool/subtool, set the file paths and check if they already exist