Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting: make click progress bar more granular #299

Closed
ewels opened this issue Apr 7, 2019 · 3 comments · Fixed by #831
Closed

Linting: make click progress bar more granular #299

ewels opened this issue Apr 7, 2019 · 3 comments · Fixed by #831
Assignees
@ewels
Labels
command line tools Anything to do with the cli interfaces linting

Comments

@ewels
Copy link
Member

ewels commented Apr 7, 2019

Currently, the progress bar kind of hangs at two points, which are themselves looping. Would be nice to break up those functions a bit so that the progress bar shows more precise updates.
@ewels ewels added linting command line tools Anything to do with the cli interfaces labels Apr 7, 2019
@ewels ewels self-assigned this Apr 7, 2019
@drpatelh
Copy link
Member

drpatelh commented Apr 7, 2019

Go go -ansi!

@ewels
Copy link
Member Author

ewels commented Dec 3, 2020

Update - the Rich progress bar that we are now using has pretty nice support for multiple progress bars: https://rich.readthedocs.io/en/latest/progress.html#advanced-usage

Should be possible to pass the progress object to the linting functions and allow them to update it however they want (or ignore it). Then we can easily have progress reporting of the nested loops - eg. for conda etc.

ewels added a commit to ewels/nf-core-tools that referenced this issue Jan 16, 2021
@ewels
Added granular progress bar for conda deps check.
4fc964f 
Closes nf-core#299

Also bumped minimum Rich version as latest release is a bug hotfix.
@ewels ewels mentioned this issue Jan 16, 2021
Merged
4 tasks
@ewels ewels linked a pull request Jan 16, 2021 that will close this issue
Added granular progress bar for conda deps check. #831
Merged
4 tasks
@ewels
Copy link
Member Author

ewels commented Feb 17, 2021

Done in #831

@ewels ewels closed this as completed Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewels ewels

Labels
command line tools Anything to do with the cli interfaces linting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added granular progress bar for conda deps check. ewels/nf-core-tools
2 participants
@ewels @drpatelh