Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sync. Again. #1072

Merged
merged 7 commits into from
May 12, 2021
Merged

Fix sync. Again. #1072

merged 7 commits into from
May 12, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented May 11, 2021

Trying to fix the automated sync again. See #1071 for debrief.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

ewels added 3 commits May 11, 2021 13:36
@ewels
Get rich traceback to use main stderr rich console
9241be7 
Should give nicer colours in GitHub actions when 💩💥
@ewels
Wrap whole sync PR code in try /except
b20c0c4 
Hopefully will mean that execution continues even when unexpected stuff breaks
@ewels
Explicitly disable requests_cache on all sync API calls
5bf75fc
@ewels ewels added the WIP Work in progress label May 11, 2021
@ewels ewels marked this pull request as ready for review May 11, 2021 20:29
@ewels ewels added ready-for-review and removed WIP Work in progress labels May 11, 2021
@ewels
Copy link
Member Author

ewels commented May 11, 2021

Ok, I figured it out - the requests library started using a special data class called CaseInsensitiveDict and dumping this to JSON triggered an error.

Easy fix - just wrapping the responses in dict() (see psf/requests#1380 (comment)).

Ended up further improving the logging and error tolerance in my efforts to get to this though, which I guess is no bad thing.

@ewels ewels linked an issue May 11, 2021 that may be closed by this pull request
1.14 sync broke again #1071
Closed
@codecov

This comment has been minimized.

Sign in to view
@ewels ewels requested a review from KevinMenden May 12, 2021 09:04
KevinMenden
KevinMenden approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay looks good as far as I can tell! 🤷

@ewels ewels merged commit 344ff29 into nf-core:dev May 12, 2021
@ewels ewels deleted the fix-sync branch May 12, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMenden KevinMenden KevinMenden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.14 sync broke again
2 participants
@ewels @KevinMenden