-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option of writing module diff to file #1254
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: need to think about flag naming with this to avoid potential confusion with #1312
Potentially:
nf-core modules update --show-diff
>nf-core modules update --update-diff
nf-core modules update --diff
>nf-core modules update --update-diff
So collapse into one file, use -
to print to stdout? (or allow empty input string if that's possible?)
Coming back to this comment, Could also have a |
ok after a bit of back and forth on this I think I'm happy - not finished yet but moving in the right direction.
Still to do before merge:
|
Can't do the Unless we add the changes to that file to the diff as well 🤔 |
ok that's pretty cool, can do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
EDIT from @ewels: Description is outdated. Usage is now via interactive prompt or
--save-diff
.Original description kept below for context:
Added option of writing the diffs in
nf-core modules update
between a locally installed module and a remote version in two ways:--diff
is specified, the user is asked whether the diffs should be displayed directly in the terminal or written to a file--diff-file <filename>
option to specify a file, without using any interactive promptsPR checklist
CHANGELOG.md
is updateddocs
is updated