Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make yamllint config recognisable by the yml lint github action #1422

Merged
merged 5 commits into from
Feb 24, 2022

Conversation

JoseEspinosa
Copy link
Member

Use this github action to enable the recognition of the yamllint.yml and avoid undesired errors.

Closes #1404

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated

@github-actions
Copy link
Contributor

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @JoseEspinosa,

It looks like this pull-request is has been made against the JoseEspinosa/nf-core-tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the JoseEspinosa/nf-core-tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@JoseEspinosa JoseEspinosa reopened this Feb 24, 2022
@JoseEspinosa JoseEspinosa changed the base branch from master to dev February 24, 2022 14:14
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #1422 (b2e0712) into dev (a1bf2ad) will not change coverage.
The diff coverage is n/a.

❗ Current head b2e0712 differs from pull request most recent head 426c157. Consider uploading reports for the commit 426c157 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1422   +/-   ##
=======================================
  Coverage   66.87%   66.87%           
=======================================
  Files          50       50           
  Lines        5688     5688           
=======================================
  Hits         3804     3804           
  Misses       1884     1884           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bf2ad...426c157. Read the comment docs.

@JoseEspinosa JoseEspinosa marked this pull request as ready for review February 24, 2022 14:17
@mashehu
Copy link
Contributor

mashehu commented Feb 24, 2022

I think we should disable the truthy checks, because it generates too many false-positives. Alternatively, add on: # yamllint disable-line rule:truthy etc. to these lines.

@JoseEspinosa
Copy link
Member Author

🚀 thanks @mashehu for the very useful suggestions!

@JoseEspinosa JoseEspinosa merged commit f1143c2 into nf-core:dev Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants