Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated URL for pipeline lint test docs #1451

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 15, 2022

When you run pipeline linting you can ctrl+click the test name and it takes you to the website. This updates to the newer URL format and also pins the version of tools that you're currently running.

Fixes #1348

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels linked an issue Mar 15, 2022 that may be closed by this pull request
Copy link
Contributor

@sateeshperi sateeshperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #1451 (22c5622) into dev (70cf924) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1451      +/-   ##
==========================================
+ Coverage   64.80%   64.81%   +0.01%     
==========================================
  Files          51       51              
  Lines        6000     6002       +2     
==========================================
+ Hits         3888     3890       +2     
  Misses       2112     2112              
Impacted Files Coverage Δ
nf_core/lint/__init__.py 70.11% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70cf924...22c5622. Read the comment docs.

@sateeshperi sateeshperi merged commit f6e2156 into nf-core:dev Mar 15, 2022
@ewels ewels deleted the update-tools-docs-url branch March 15, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin version in URL for lint errors
2 participants