Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String stuff #1596

Merged
merged 16 commits into from
May 25, 2022
Merged

String stuff #1596

merged 16 commits into from
May 25, 2022

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented May 18, 2022

This PR aims to harmonize the use of strings and fix a lot of minor issues related with strings and regexes.

NB: the regex fix change has been reverted to make this a PR purely focussing on string formatting.

I don't think a changelog is necessary for this PR because it does not affect the behaviour of the code.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1596 (200c20a) into dev (201b3e0) will increase coverage by 0.01%.
The diff coverage is 58.84%.

@@            Coverage Diff             @@
##              dev    #1596      +/-   ##
==========================================
+ Coverage   64.63%   64.65%   +0.01%     
==========================================
  Files          54       54              
  Lines        6249     6232      -17     
==========================================
- Hits         4039     4029      -10     
+ Misses       2210     2203       -7     
Impacted Files Coverage Δ
nf_core/create.py 85.93% <0.00%> (ø)
nf_core/licences.py 25.00% <0.00%> (ø)
nf_core/lint/actions_awsfulltest.py 88.88% <0.00%> (ø)
nf_core/lint/actions_awstest.py 83.33% <0.00%> (ø)
nf_core/lint/multiqc_config.py 80.43% <0.00%> (ø)
nf_core/lint/readme.py 79.31% <ø> (ø)
nf_core/lint/schema_lint.py 81.81% <0.00%> (ø)
nf_core/lint/schema_params.py 76.00% <0.00%> (ø)
nf_core/modules/lint/module_changes.py 76.00% <ø> (ø)
nf_core/modules/lint/module_deprecations.py 85.71% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201b3e0...200c20a. Read the comment docs.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)
Added a couple of suggestions of strings that can also be formatted, I hope I didn't forget too many!

nf_core/lint/__init__.py Outdated Show resolved Hide resolved
nf_core/lint/__init__.py Outdated Show resolved Hide resolved
nf_core/modules/lint/__init__.py Outdated Show resolved Hide resolved
@fabianegli fabianegli force-pushed the string-stuff branch 2 times, most recently from 95abd9f to b18aaa3 Compare May 22, 2022 14:53
@fabianegli fabianegli requested a review from mirpedrol May 25, 2022 10:27
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@fabianegli fabianegli merged commit 67b2b48 into nf-core:dev May 25, 2022
@fabianegli
Copy link
Contributor Author

Thank you 😃

@fabianegli fabianegli deleted the string-stuff branch July 21, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants