-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String stuff #1596
String stuff #1596
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1596 +/- ##
==========================================
+ Coverage 64.63% 64.65% +0.01%
==========================================
Files 54 54
Lines 6249 6232 -17
==========================================
- Hits 4039 4029 -10
+ Misses 2210 2203 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Added a couple of suggestions of strings that can also be formatted, I hope I didn't forget too many!
95abd9f
to
b18aaa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Thank you 😃 |
This PR aims to harmonize the use of strings and fix a lot of minor issues related with strings and regexes.
NB: the regex fix change has been reverted to make this a PR purely focussing on string formatting.
I don't think a changelog is necessary for this PR because it does not affect the behaviour of the code.
PR checklist
CHANGELOG.md
is updateddocs
is updated