Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #1613 #1618

Merged
merged 6 commits into from
Jun 28, 2022
Merged

Fix Issue #1613 #1618

merged 6 commits into from
Jun 28, 2022

Conversation

sguizard
Copy link
Contributor

@sguizard sguizard commented Jun 1, 2022

PR checklist

Fixing #1613
Update the regexp to accept any characters except numbers, dot and dash before number version.

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!

@sguizard sguizard changed the title Fix https://github.com/nf-core/tools/issues/1613 Fix Issue #1613 Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1618 (4366c78) into dev (8877e4a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1618   +/-   ##
=======================================
  Coverage   64.68%   64.68%           
=======================================
  Files          54       54           
  Lines        6281     6281           
=======================================
  Hits         4063     4063           
  Misses       2218     2218           
Impacted Files Coverage Δ
nf_core/lint/readme.py 79.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8877e4a...4366c78. Read the comment docs.

nf_core/lint/readme.py Outdated Show resolved Hide resolved
@fabianegli
Copy link
Contributor

I wonder how Nextflow parses version numbers. There might be a possibility to harmonize that.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErikDanielsson ErikDanielsson merged commit 9bd0355 into nf-core:dev Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants