Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-core tasks shouldn't request more than 1 core #1678

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Conversation

muffato
Copy link
Member

@muffato muffato commented Jul 15, 2022

Follow-up of #1630 . For single-core tasks, there is no need to increase the number of cores at each attempt

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@muffato muffato requested a review from matthdsm July 15, 2022 12:46
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1678 (0fd5cdc) into dev (d5ee441) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1678   +/-   ##
=======================================
  Coverage   68.00%   68.00%           
=======================================
  Files          56       56           
  Lines        6589     6589           
=======================================
  Hits         4481     4481           
  Misses       2108     2108           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ee441...0fd5cdc. Read the comment docs.

@matthdsm
Copy link
Contributor

Looks good and makes more sense than it did previously!

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthdsm
Copy link
Contributor

Thanks!

@matthdsm matthdsm merged commit ed355ed into dev Jul 15, 2022
@matthdsm matthdsm deleted the muffato-patch-1 branch July 15, 2022 13:21
@muffato
Copy link
Member Author

muffato commented Jul 15, 2022

Thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants