Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --key flag for nf-core lint for module lint tests #1682

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

ErikDanielsson
Copy link
Contributor

@ErikDanielsson ErikDanielsson commented Jul 19, 2022

When running nf-core module --key <module-test> all pipeline lint tests were run in addition to the supplied module test (#1681). With this PR only the tests specified by the --key option are run

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1682 (27d08b4) into dev (cc1ab61) will decrease coverage by 0.06%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##              dev    #1682      +/-   ##
==========================================
- Coverage   67.99%   67.93%   -0.07%     
==========================================
  Files          56       56              
  Lines        6609     6614       +5     
==========================================
- Hits         4494     4493       -1     
- Misses       2115     2121       +6     
Impacted Files Coverage Δ
nf_core/lint/__init__.py 73.66% <36.36%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1ab61...27d08b4. Read the comment docs.

@ErikDanielsson ErikDanielsson linked an issue Jul 19, 2022 that may be closed by this pull request
@ErikDanielsson ErikDanielsson requested a review from mirpedrol July 21, 2022 07:24
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ErikDanielsson
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nf-core lint --key <module_test> runs pipeline lint tests
2 participants