-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint for container names #1683
Lint for container names #1683
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## dev #1683 +/- ##
==========================================
+ Coverage 67.99% 68.13% +0.14%
==========================================
Files 56 56
Lines 6614 6637 +23
==========================================
+ Hits 4497 4522 +25
+ Misses 2117 2115 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think this will be really helpful :) thanks!
Added lint test to check that the container names in modules are parsable, as was suggested in #1654. To have the possibility of making the warned module lint test more prominent, I also added a
--fail-warned
flag. This flag is not activated whennf-core lint
is run with its--fail-warned
flag, since this will make the "Create and lint pipeline" GH action fail. (An idea on how to solve this is suggested in #1684)PR checklist
CHANGELOG.md
is updateddocs
is updated