Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #1706

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Remove unused imports #1706

merged 4 commits into from
Jul 28, 2022

Conversation

fabianegli
Copy link
Contributor

Mostly removal of unused imports, with two minor off-topic additions: 1. cleanup of imports in refgenie and 2. replacement of deprecated calls to log.warn.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #1706 (eb4e378) into dev (ca4bd32) will increase coverage by 0.22%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev    #1706      +/-   ##
==========================================
+ Coverage   67.98%   68.21%   +0.22%     
==========================================
  Files          56       57       +1     
  Lines        6694     6736      +42     
==========================================
+ Hits         4551     4595      +44     
+ Misses       2143     2141       -2     
Impacted Files Coverage Δ
nf_core/__main__.py 52.84% <ø> (-0.22%) ⬇️
nf_core/bump_version.py 89.65% <ø> (-0.18%) ⬇️
nf_core/launch.py 63.84% <ø> (-0.10%) ⬇️
nf_core/licences.py 23.94% <ø> (-1.06%) ⬇️
nf_core/lint/actions_schema_validation.py 90.32% <ø> (-0.31%) ⬇️
nf_core/lint/modules_json.py 80.00% <ø> (-0.77%) ⬇️
nf_core/lint/schema_description.py 67.85% <ø> (-1.11%) ⬇️
nf_core/lint/schema_lint.py 75.86% <ø> (-0.81%) ⬇️
nf_core/modules/bump_versions.py 64.40% <ø> (-0.20%) ⬇️
nf_core/modules/lint/main_nf.py 66.39% <ø> (-0.14%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4bd32...eb4e378. Read the comment docs.

Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nf_core/modules/info.py Show resolved Hide resolved
@ErikDanielsson ErikDanielsson merged commit 3c22ebb into nf-core:dev Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants