Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add base_path to ModuleInfo init method #1720

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Aug 2, 2022

Closes #1719

Adding missing argument base_path to ModuleInfo init method.
Part of implementation of git remotes in #1641 (Issue #1626 )

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1720 (625ad23) into dev (92211f3) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##              dev    #1720   +/-   ##
=======================================
  Coverage   68.29%   68.29%           
=======================================
  Files          59       59           
  Lines        7078     7078           
=======================================
  Hits         4834     4834           
  Misses       2244     2244           
Impacted Files Coverage Δ
nf_core/modules/info.py 16.92% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@mirpedrol mirpedrol marked this pull request as ready for review August 2, 2022 13:59
Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mirpedrol mirpedrol merged commit 53c9dc7 into nf-core:dev Aug 2, 2022
@mirpedrol mirpedrol deleted the moduleinfo branch August 2, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants