-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require an argument for nf-core schema lint
#2225
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2225 +/- ##
=======================================
Coverage 72.88% 72.88%
=======================================
Files 78 78
Lines 8372 8372
=======================================
Hits 6102 6102
Misses 2270 2270 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This all looks good to me. The default works fine as a string in my testing. Indeed I believe Do we need to add a test for this command that uses the default? |
I can't see any existing tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Remember to update the changelog though ;) |
1ee139b
to
b4e22d3
Compare
Python linting (
|
nf-core lint
andnf-core modules lint
can both be called with no arguments, butnf-core schema lint
requires that you pass the path to the schema. Since this will often just be at./nextflow_schema.json
, defaulting to that reduces the length of the invocation in the common case and makes the usage of all three lint commands more consistent.I'm not 100% sure of how
click.Path
works – is just providing a string as the default here correct? should I be using some otherPath
type?Also I don't know how the fancy images in the readme get generated, I'm hoping based on looking at the commit history for them that there's some magic github action that will kick in once I open the PR...
Fixes #1838
PR checklist
CHANGELOG.md
is updated