-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting error if quay.io found in biocontainer name #2278
Linting error if quay.io found in biocontainer name #2278
Conversation
Changes: - Linting error if container starts with quay.io/biocontainers but not quay.io/biocontainers/mulled Fixes nf-core#2276
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
For a separate issue / PR - this file really needs breaking into many smaller ones with different tests. Also the docs are severely lacking.. 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, need to add a self.passed
when the test is passing..
Do we want one for the general container? E.g. if docker image name looks valid ✅ |
Puts container status check into a single if statement
Nevermind, I've copied the existing format. Also updated one of the checks to occur once. |
@drpatelh This PR now changes if you are removing |
Codecov Report
@@ Coverage Diff @@
## dev #2278 +/- ##
==========================================
+ Coverage 73.05% 73.12% +0.07%
==========================================
Files 77 77
Lines 8424 8433 +9
==========================================
+ Hits 6154 6167 +13
+ Misses 2270 2266 -4
|
Changes:
Fixes #2276
PR checklist
CHANGELOG.md
is updateddocs
is updated