Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ignored config variables #2507

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Ignore ignored config variables #2507

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c2c995
Ignore ignored config variables
rernst Nov 9, 2023
4ad4bb7
Update CHANGELOG.md
rernst Nov 9, 2023
e936ac3
Update CHANGELOG.md
rernst Nov 13, 2023
914420b
Merge branch 'dev' into dev
rernst Nov 13, 2023
1f375af
Merge branch 'dev' into dev
rernst Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Fix incorrectly failing linting if 'modules' was not found in meta.yml ([#2447](https://github.com/nf-core/tools/pull/2447))
- Correctly pass subworkflow linting test if `COMPONENT.out.versions` is used in the script ([#2448](https://github.com/nf-core/tools/pull/2448))
- Check for spaces in modules container URLs ([#2452](https://github.com/nf-core/tools/issues/2452))
- Correctly ignore `timeline.enabled`, `report.enabled`, `trace.enabled`, `dag.enabled` variables. ([#2507](https://github.com/nf-core/tools/pull/2507))
rernst marked this conversation as resolved.
Show resolved Hide resolved

### Modules

Expand Down
2 changes: 2 additions & 0 deletions nf_core/lint/nextflow_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@ def nextflow_config(self):

# Check the variables that should be set to 'true'
for k in ["timeline.enabled", "report.enabled", "trace.enabled", "dag.enabled"]:
if k in ignore_configs:
continue
if self.nf_config.get(k) == "true":
passed.append(f"Config ``{k}`` had correct value: ``{self.nf_config.get(k)}``")
else:
Expand Down