Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve testing coverage for meta_yml #2539

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Nov 27, 2023

No description provided.

@mashehu mashehu requested a review from mirpedrol November 27, 2023 09:46
# Conflicts:
#	tests/modules/lint.py
#	tests/test_modules.py
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (8b4addf) 74.84% compared to head (341dbdf) 74.95%.

Files Patch % Lines
nf_core/components/list.py 63.63% 8 Missing ⚠️
nf_core/components/nfcore_component.py 90.00% 4 Missing ⚠️
nf_core/modules/modules_utils.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2539      +/-   ##
==========================================
+ Coverage   74.84%   74.95%   +0.10%     
==========================================
  Files          85       85              
  Lines        9184     9231      +47     
==========================================
+ Hits         6874     6919      +45     
- Misses       2310     2312       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only a couple of comments :)

nf_core/components/nfcore_component.py Outdated Show resolved Hide resolved
nf_core/components/nfcore_component.py Outdated Show resolved Hide resolved
nf_core/components/nfcore_component.py Outdated Show resolved Hide resolved
@mashehu mashehu merged commit db3c449 into nf-core:dev Nov 27, 2023
19 checks passed
@mashehu mashehu deleted the test-modules-bump branch November 27, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants