Add nf_core_version to .nf-core.yml

[Joon-Klaps]

#2741

PR checklist

• This comment contains a description of changes (with reason)
• CHANGELOG.md is updated
• If you've fixed a bug or added code that should be tested, add tests!
• Documentation in docs is updated

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 74.76%. Comparing base (2cb50ca) to head (099c01d).

❗ Current head 099c01d differs from pull request most recent head 1fc8080. Consider uploading reports for the commit 1fc8080 to get more accurate results

Files	Patch %	Lines
nf_core/lint/nfcore_yml.py	0.00%	5 Missing ⚠️

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mashehu]

@mirpedrol is that conflicting with #2404 ?

[mirpedrol]

Looking good!
I think we should add a pipeline linting test to make sure the .nf-core.yml contains the version :)

@mirpedrol is that conflicting with #2404 ?

Should be fine! It is only modifying a template file, not the create.py code

[mashehu]

applied some last polish to it, now it's good to go.

[mashehu]

Not sure if this file name is ever written like that, it should be created by the tools, so no need for this extra check 🙂

[Joon-Klaps]

Was because I read this somewhere.

tools/nf_core/utils.py

Line 1011 in 1148c4e

CONFIG_PATHS = [".nf-core.yml", ".nf-core.yaml"]

tools/CHANGELOG.md

Line 685 in 1148c4e

- Don't allow a `.nf-core.yaml` file, should be `.yml` ([#1515](https://github.com/nf-core/tools/pull/1515)).

So i thought to keep it in there as some pipeline still might have the deprecated yaml.

[mashehu]

ah, good point. we leave it in then. 🙂 it seems to be just cutandrun for now: https://github.com/search?q=path%3A.nf-core.yaml&type=code

[mashehu]

the AttributeError: 'called_once_with' is not a valid assertion. Use a spec for the mock if 'called_once_with' is meant to be an attribute.. Did you mean: 'assert_called_once_with'? errors are a known issue #2891, can be ignored for now