Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieving module information of input and output and EDAM ontology from bio.tools #3418

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Jan 21, 2025

Working on nf-core/modules#5831

TO DO:

  • Use the new functionality to update the meta.yml when linting. Update update_meta_yml_file() function at nf_core/modules/lint/__init__.py
  • Fix mypy errors
  • Fix new lines and trailing spaces in meta.yml
  • Use the new information to generate the main.nf with it
  • Possibly also use it for main.nf.test
  • Add tests

@mirpedrol mirpedrol changed the title first implementation of retrieving module information of input and ou… Retrieving module information of input and output from bio.tools Jan 21, 2025
@mirpedrol mirpedrol changed the title Retrieving module information of input and output from bio.tools Retrieving module information of input and output and EDAM ontology from bio.tools Jan 21, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 21 lines in your changes missing coverage. Please review.

Project coverage is 76.39%. Comparing base (0716d91) to head (135f5da).
Report is 61 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/components/components_utils.py 47.36% 20 Missing ⚠️
nf_core/modules/lint/__init__.py 50.00% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nf_core/components/components_utils.py Outdated Show resolved Hide resolved
nf_core/components/components_utils.py Outdated Show resolved Hide resolved

# If the tool name was not found in the response
log.warning(f"Could not find a bio.tools ID for '{tool_name}'")
return ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it isn't better to always return None if we don't get a correct entry, like we do in the function above

nf_core/components/components_utils.py Outdated Show resolved Hide resolved
nf_core/components/components_utils.py Outdated Show resolved Hide resolved
nf_core/components/components_utils.py Outdated Show resolved Hide resolved
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants