Changes nf-core cache dir to user's home

[sven1103]

Fixes #379 .

PR checklist

• This comment contains a description of changes (with reason)
• If you've fixed a bug or added code that should be tested, add tests!
• Documentation in docs is updated
• CHANGELOG.md is updated
• README.md is updated

Learn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md

[lgtm-com]

This pull request introduces 1 alert when merging bd28114 into c34b04b - view on LGTM.com

new alerts:

• 1 for Unused import

[apeltzer]

The import temfile can be dropped according to:

https://lgtm.com/projects/g/nf-core/tools/rev/pr-78a866159bbc8065b95d1ea9b362de23429a32d8

[ewels]

In fact, instead of using the user's home directory, can we not just add in a user-specific subdir on the temp path? Needs to be persistent between runs though. Maybe os.getlogin()?

os.path.join(tempfile.gettempdir(), os.getlogin(), 'nfcore_cache')

[sven1103]

In fact, instead of using the user's home directory, can we not just add in a user-specific subdir on the temp path? Needs to be persistent between runs though. Maybe os.getlogin()?

os.path.join(tempfile.gettempdir(), os.getlogin(), 'nfcore_cache')

I think the home dir is a better solution, because the tmp folder might not be persistent. Depending on the system setup, it might get deleted regularly. And we do not want that for the request cache imo :)

[lgtm-com]

This pull request introduces 1 alert when merging 03b507a into f71f037 - view on LGTM.com

new alerts:

• 1 for Unused import

[sven1103]

@ewels better?

[apeltzer]

@sven1103 you broke the tests!