Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1.6.1 #388

Closed
wants to merge 2 commits into from
Closed

Patch 1.6.1 #388

wants to merge 2 commits into from

Conversation

sven1103
Copy link
Member

Hotfix for the invalid parameter schema URL

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md

@apeltzer
Copy link
Member

Going straight to mastertherefore TravisCI fails - intended to have a 1.6.1 release before we do the 1.7.0 ?

@sven1103
Copy link
Member Author

Going straight to mastertherefore TravisCI fails - intended to have a 1.6.1 release before we do the 1.7.0 ?

Yes, to roll-out the broken link quickly. That was my intention :)

@ewels
Copy link
Member

ewels commented Oct 5, 2019

Seeing as we are intending to release v1.7 tomorrow, I'm going to change the base for this PR to dev.

We should still allow patch releases, but here I see no reason for it. Feel free to complain if you disagree 😅

@ewels ewels changed the base branch from master to dev October 5, 2019 22:26
@ewels ewels added this to the 1.7 milestone Oct 5, 2019
@ewels ewels added bug Something isn't working high-priority labels Oct 5, 2019
@apeltzer
Copy link
Member

apeltzer commented Oct 6, 2019

Patch releases will be enabled after #404 is merged in here, so in the future we can do such releases now 👍

I don't see an issue to have this now in dev and fixed in the upcoming release therefore 👍

@apeltzer
Copy link
Member

apeltzer commented Oct 6, 2019

(though we can close this now, as it is already contained in the dev branch and fixed there!)

@apeltzer apeltzer closed this Oct 6, 2019
@ewels ewels deleted the patch-1.6.1 branch October 6, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants