Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint validation #853

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Lint validation #853

merged 3 commits into from
Feb 16, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented Feb 16, 2021

Check for new files added in the now-merged #852 - fail if not present.

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #853 (daca4be) into dev (3f44a18) will not change coverage.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #853   +/-   ##
=======================================
  Coverage   75.02%   75.02%           
=======================================
  Files          22       22           
  Lines        2755     2755           
=======================================
  Hits         2067     2067           
  Misses        688      688           
Impacted Files Coverage Δ
nf_core/lint/files_unchanged.py 72.60% <25.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f44a18...daca4be. Read the comment docs.

Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

@ewels ewels merged commit 95b9d6f into nf-core:dev Feb 16, 2021
@ewels ewels deleted the lint-validation branch March 16, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants