Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch fix triage #1 #919

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Patch fix triage #1 #919

merged 3 commits into from
Mar 19, 2021

Conversation

KevinMenden
Copy link
Contributor

@KevinMenden KevinMenden commented Mar 19, 2021

This fixes the following issues:

  • removing emit statements doesn't lead to failure
  • conda version parsing not robust

@KevinMenden KevinMenden linked an issue Mar 19, 2021 that may be closed by this pull request
3 tasks
@KevinMenden KevinMenden removed a link to an issue Mar 19, 2021
3 tasks
@KevinMenden KevinMenden mentioned this pull request Mar 19, 2021
3 tasks
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #919 (1d3f716) into dev (8648c11) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #919      +/-   ##
==========================================
- Coverage   69.58%   69.57%   -0.01%     
==========================================
  Files          34       34              
  Lines        4162     4164       +2     
==========================================
+ Hits         2896     2897       +1     
- Misses       1266     1267       +1     
Impacted Files Coverage Δ
nf_core/modules/lint.py 62.55% <25.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8648c11...1d3f716. Read the comment docs.

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would normally say changelog, but as this is for linting that is so new no need I think 👍🏻

@ewels ewels merged commit ccd9ef1 into nf-core:dev Mar 19, 2021
@KevinMenden
Copy link
Contributor Author

Yeah sorry didn't think about the changelog :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants