-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing bugs in nf-core create #936
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #936 +/- ##
==========================================
+ Coverage 69.56% 69.61% +0.05%
==========================================
Files 34 34
Lines 4173 4180 +7
==========================================
+ Hits 2903 2910 +7
Misses 1270 1270
Continue to review full report at Codecov.
|
What I've done so far:
|
@apeltzer I think that's all I can add here for now, whenever you have time to test quickly on your special system 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeeaaahh... can I be a douche and have a stab at implementing this? I was coding it in my head in the car this afternoon and I think I can do it in a slightly more elegant way (even though your code should be entirely functional).
Rebased to hide my lack of local testing. Hopefully Kevin doesn't read his GitHub email notifications.. 👀
This PR tries to address the bugs in #931
closes #931
(once ready)