Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline create - apply file permissions to new files #944

Merged
merged 5 commits into from
Mar 23, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 23, 2021

Get the file mode from the template file and apply it to the new file in nf-core create

Fixes #932

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #944 (b28dcaf) into dev (e0f0d1b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head b28dcaf differs from pull request most recent head 618179c. Consider uploading reports for the commit 618179c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #944      +/-   ##
==========================================
+ Coverage   69.61%   69.64%   +0.02%     
==========================================
  Files          34       34              
  Lines        4180     4184       +4     
==========================================
+ Hits         2910     2914       +4     
  Misses       1270     1270              
Impacted Files Coverage Δ
nf_core/create.py 93.26% <100.00%> (+0.13%) ⬆️
nf_core/modules/create.py 60.91% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f0d1b...618179c. Read the comment docs.

@ewels ewels linked an issue Mar 23, 2021 that may be closed by this pull request
Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Kevin Menden <[email protected]>
@ewels ewels enabled auto-merge March 23, 2021 10:58
@ewels ewels merged commit cb5313d into nf-core:dev Mar 23, 2021
@ewels ewels deleted the jinja-file-perms branch March 26, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executables in bin/ don't have write permissions with nf-core create
2 participants