Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duration parsing #974

Merged
merged 6 commits into from
Mar 26, 2021
Merged

Fix duration parsing #974

merged 6 commits into from
Mar 26, 2021

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Mar 26, 2021

To close #973

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@jfy133 jfy133 requested review from KevinMenden and ewels March 26, 2021 12:24
@github-actions
Copy link
Contributor

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @jfy133,

It looks like this pull-request is has been made against the jfy133/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the jfy133/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@jfy133 jfy133 changed the base branch from master to dev March 26, 2021 12:24
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #974 (455b5ef) into dev (f89a043) will not change coverage.
The diff coverage is n/a.

❗ Current head 455b5ef differs from pull request most recent head 624b360. Consider uploading reports for the commit 624b360 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #974   +/-   ##
=======================================
  Coverage   69.27%   69.27%           
=======================================
  Files          34       34           
  Lines        4225     4225           
=======================================
  Hits         2927     2927           
  Misses       1298     1298           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a9abc...624b360. Read the comment docs.

Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙂 👍

CHANGELOG.md Outdated Show resolved Hide resolved
@ewels ewels enabled auto-merge March 26, 2021 13:09
@ewels ewels merged commit abd8809 into nf-core:dev Mar 26, 2021
@jfy133 jfy133 deleted the fix-duration-parsing branch March 26, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema validation of time resources doesn't work when param loaded from config
3 participants