Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and fix ECLint in pipeline #188

Merged
merged 18 commits into from
May 12, 2021
Merged

Add and fix ECLint in pipeline #188

merged 18 commits into from
May 12, 2021

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented May 11, 2021

  • Add EditorConfig linting similar to Editorconfig rnaseq#627
  • Simplified default comments everywhere because ECLint was left-aligning them and they looked terrible.
  • Changed comment header format in all of the template files too

This took way longer than I wanted it to but the code base should be even nicer and more consistent going forward!!

All of the tests seem to be happy so I hope I haven't broke something somewhere with all of this re-formatting! Bit late in the day now given we are releasing soon. Oh well 🤷🏽

@drpatelh drpatelh changed the title Fix whitespace everywhere 🤦🏽 Add and fix ECLint in pipelin May 11, 2021
@drpatelh drpatelh changed the title Add and fix ECLint in pipelin Add and fix ECLint in pipeline May 11, 2021
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but otherwise awesome as always 👍

.markdownlint.yml Show resolved Hide resolved
@@ -1,19 +1,17 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we open an issue to update the comments when using nf-core modules create?
Although, this will also require to update/reinstall all the functions.nf on modules/nf-core/software 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please 👀 Will need to look for these comments in the entire module repo. Copying the functions.nf shouldn't be much work. Think I have a script for that 🤔 Problem is that they get left-aligned with the new EClint which makes everything untidy so better to just replace them once and for all everywhere I think.

subworkflows/local/variants_ivar.nf Show resolved Hide resolved
@drpatelh
Copy link
Member Author

drpatelh commented May 12, 2021

We good to go here @JoseEspinosa ?

Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants