-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and fix ECLint in pipeline #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but otherwise awesome as always 👍
@@ -1,19 +1,17 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we open an issue to update the comments when using nf-core modules create
?
Although, this will also require to update/reinstall all the functions.nf
on modules/nf-core/software
😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please 👀 Will need to look for these comments in the entire module repo. Copying the functions.nf
shouldn't be much work. Think I have a script for that 🤔 Problem is that they get left-aligned with the new EClint which makes everything untidy so better to just replace them once and for all everywhere I think.
We good to go here @JoseEspinosa ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This took way longer than I wanted it to but the code base should be even nicer and more consistent going forward!!
All of the tests seem to be happy so I hope I haven't broke something somewhere with all of this re-formatting! Bit late in the day now given we are releasing soon. Oh well 🤷🏽