Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] name of binaries #238

Closed
Brilator opened this issue Jan 25, 2024 · 6 comments
Closed

[Feature Request] name of binaries #238

Brilator opened this issue Jan 25, 2024 · 6 comments

Comments

@Brilator
Copy link
Member

Regarding https://github.com/nfdi4plants/ARCCommander/releases/tag/v1.0.0

There's an issue with the names of the binaries / executables: arc_<OS>. All docs are written for arc ....

Option 1: The way it was before, having one release per OS.

Option 2: We adapt the installation, so that arc_<OS> is moved and added to $PATH as arc

Option 3: Only rename the windows executable to arc.exe, since on Linux and macOS we need to install "by hand" anyways (and follow option 2 there)

@HLWeil
Copy link
Member

HLWeil commented Jan 25, 2024

Thanks for the input, I agree that we need some sort of solution.

I'm really not a friend of Option 1. That's why I did the change. It clutteres the release history a lot. And the whole latest thing is kinda broken.

With Option 2 you mean having a rename step in the installation guide?

@Brilator
Copy link
Member Author

With Option 2 you mean having a rename step in the installation guide?

Yes. See PR linked above.

@HLWeil
Copy link
Member

HLWeil commented Jan 25, 2024

I'd say go. With the ARCitect taking the role as the community tool, the ARCCommander is becoming a niche tool for enthusiasts. They will probably manage a rename

@Brilator
Copy link
Member Author

Alright. Would it still be easily automated to call the win thing arc.exe?
So the windows people would still have the convenience of click-downloading (balanced with the inconvenience of adding to PATH)

@HLWeil
Copy link
Member

HLWeil commented Jan 25, 2024

Technically this would be a no-brainer, but it feels like a disturbance in the force (of order).

@HLWeil
Copy link
Member

HLWeil commented Jan 25, 2024

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants