Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] parseTableColumn and parseColumn naming is interchanged #14

Closed
omaus opened this issue Jul 14, 2023 · 0 comments · Fixed by #15
Closed

[BUG] parseTableColumn and parseColumn naming is interchanged #14

omaus opened this issue Jul 14, 2023 · 0 comments · Fixed by #15
Assignees
@omaus

Comments

@omaus
Copy link
Collaborator

omaus commented Jul 14, 2023

https://github.com/nfdi4plants/ArcGraphModel/blob/74c57e61aa5cd798cf0702f9daab053b14af32b2/src/ArcGraphModel.IO/ISA/Worksheet.fs#L24-L37

The name is parseColumn but it parses the columns of the worksheet's first table while

https://github.com/nfdi4plants/ArcGraphModel/blob/74c57e61aa5cd798cf0702f9daab053b14af32b2/src/ArcGraphModel.IO/ISA/Worksheet.fs#L39-L52

parses the columns of the whole worksheet, ignoring tables though the name is parseTableColumns.

This means, the names are mixed up.
@omaus omaus self-assigned this Jul 14, 2023
omaus added a commit that referenced this issue Jul 14, 2023
@omaus
Fix interchanged names
e8cde7b 
Fixes #14.
@omaus omaus changed the title [BUG] parseTableColumn and parseColumn` naming is interchanged [BUG] parseTableColumn and parseColumn naming is interchanged Jul 14, 2023
@omaus omaus mentioned this issue Jul 14, 2023
Merged
@omaus omaus closed this as completed in #15 Jul 17, 2023
omaus added a commit that referenced this issue Jul 17, 2023
@omaus
Merge pull request #15 from nfdi4plants/bug-namesInterchanged-#14
14e049f 
#14 Fix interchanged names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omaus omaus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#14 Fix interchanged names nfdi4plants/ARCTokenization
1 participant
@omaus