Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework types #9

Merged
merged 2 commits into from
Apr 23, 2023
Merged

Rework types #9

merged 2 commits into from
Apr 23, 2023

Conversation

HLWeil
Copy link
Member

@HLWeil HLWeil commented Apr 23, 2023

Changes

  • added IParam interface which references both ICvBase and IParamBase
  • make CvParam and UserParam implement this interface
  • changed Qualifiers to Attributes, which are now stores in a CvAttributeCollection type. All main types inherit from this
  • CvContainers now inherit from CvAttributeCollection, and contain their properties as a field
  • Added loads of access and helper methods and functions

Note

The tests repo does currently not build, as the types were majorly reworked. But won't be adjusted till the Fable branch is integrated, where the tests were compeletely overhauled.

@HLWeil HLWeil merged commit 013b381 into main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HLWeil @omaus