Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops separate PlainComponent file, makes series of small optimizations #223

Merged
merged 1 commit into from
Jan 15, 2017
Merged

Drops separate PlainComponent file, makes series of small optimizations #223

merged 1 commit into from
Jan 15, 2017

Conversation

lourd
Copy link
Contributor

@lourd lourd commented Jan 8, 2017

  • Since all PlainComponent did was render null, there's no need to make
    it class-based or a separate file. Doing a null-returning function
    inline saves some overhead
  • Refactored some functions to use reduce and insert the spaces within
    the higher-order function instead of joining and trimming afterward
  • Adds explicit name/reference for HelmetSideEffects and passes that to
    the Helmet wrapper
  • Makes some small changes around indentation, returning earlier, and
    implicit returns from arrow functions

- Since all PlainComponent did was render null, there's no need to make
it class-based or a separate file. Doing a null-returning function
inline saves some overhead
- Refactored some functions to use `reduce` and insert the spaces within
the higher-order function instead of joining and trimming afterward
- Adds explicit name/reference for HelmetSideEffects and passes that to
the Helmet wrapper
- Makes some small changes around indentation, returning earlier, and
implicit returns from arrow functions
@cwelch5
Copy link
Contributor

cwelch5 commented Jan 15, 2017

Thanks @lourd !

@cwelch5 cwelch5 merged commit 042b38d into nfl:master Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants