Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some element IDs use underscores and others use dashes #18

Open
nfoert opened this issue Jul 2, 2024 · 5 comments
Open

Some element IDs use underscores and others use dashes #18

nfoert opened this issue Jul 2, 2024 · 5 comments
Assignees
Labels
awaiting merge Awaiting branch merges to be completed bug Something isn't working client A change to client-side code hacktoberfest A good issue for hacktoberfest 2024

Comments

@nfoert
Copy link
Owner

nfoert commented Jul 2, 2024

I'm not really sure how this happened. The IDs with dashes (-) should be replaced to use underscores (_) instead.

@nfoert nfoert added bug Something isn't working client A change to client-side code labels Jul 2, 2024
@nfoert nfoert self-assigned this Jul 2, 2024
@mSaurabh
Copy link

mSaurabh commented Oct 6, 2024

@nfoert is this like a major refactor? If so, would you think it would be ideal after the automated tests have been implemented then we should tackle this?

@nfoert
Copy link
Owner Author

nfoert commented Oct 6, 2024

@mSaurabh, it's not too much of a change, there's just a few element IDs from the first few weeks of this project using dashes instead of underscores, it could probably be fixed now, it's just not something that I've gotten around to yet

@mSaurabh
Copy link

mSaurabh commented Oct 7, 2024

I can take this quick clean up @nfoert

@nfoert
Copy link
Owner Author

nfoert commented Oct 7, 2024

Sounds good, thank you @mSaurabh!

@nfoert nfoert assigned mSaurabh and unassigned nfoert Oct 7, 2024
@nfoert nfoert added the hacktoberfest A good issue for hacktoberfest 2024 label Oct 7, 2024
mSaurabh added a commit to mSaurabh/cardie-hacktoberfest that referenced this issue Oct 19, 2024
@mSaurabh
Copy link

@nfoert I have refactored the code. Here's the PR.

nfoert added a commit that referenced this issue Oct 20, 2024
@nfoert nfoert added the awaiting merge Awaiting branch merges to be completed label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting branch merges to be completed bug Something isn't working client A change to client-side code hacktoberfest A good issue for hacktoberfest 2024
Projects
None yet
Development

No branches or pull requests

2 participants