Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX problem color #45

Closed
GoNode5 opened this issue Sep 28, 2017 · 5 comments
Closed

UX problem color #45

GoNode5 opened this issue Sep 28, 2017 · 5 comments
Assignees
Labels

Comments

@GoNode5
Copy link

GoNode5 commented Sep 28, 2017

Very nice component.

select1problem

The first selection staying highlighted this is also confusing...
Besides color could/would it possible to to put an Icon 'tick' for the one(s) selected as extra?

@anjmao anjmao added the bug label Sep 29, 2017
@anjmao
Copy link
Member

anjmao commented Sep 29, 2017

Thanks for reporting. This is known issue and should be fixed soon :) For putting you custom item you can use custom option template. See example https://github.com/ng-select/ng-select#custom-display-and-option-templates

@anjmao anjmao added this to the Version 1.0.0 milestone Sep 29, 2017
@anjmao anjmao assigned anjmao and varnastadeus and unassigned anjmao Sep 29, 2017
@varnastadeus
Copy link
Member

@GoNode5 custom templates are supported only for single select for now, if that is what you are asking.

@anjmao
Copy link
Member

anjmao commented Sep 29, 2017

@varnastadeus Option custom templates are supported for both single and multiselect. Label templates are supported only in single select because it is much more complex. Probably we need to document this.

@GoNode5
Copy link
Author

GoNode5 commented Sep 29, 2017

thnx for all your comments. I'am now using Chosen (jquery plugin), but would like to use native Angular. With Chosen, selected items are grey. Although possible I almost never have to need or I filter disabled options that can't be selected anyway. Or show strikethrough? or make it CSS optional for all 3 options...
Chosen options (https://harvesthq.github.io/chosen/options.html) are all viable usage that will be request/features ask by users later on.

varnastadeus pushed a commit that referenced this issue Sep 29, 2017
@varnastadeus
Copy link
Member

varnastadeus commented Sep 29, 2017

@GoNode5 Regarding colors, current style is provided as baseline and since we can't match everyone's preference we will keep it that way, although there might be some slight changes in the future. If you want, you can customize it yourself e.g.

ng-select .as-option.selected {
    background-color: red!important;
}

I added pull request #49 which fixes issue you mentioned The first selection staying highlighted.... As to other features, please feel free to create new issues and we will consider implementing it.

jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
* refactor: keep marked item as reference

* fix: mark item on hover fixes ng-select#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants