Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit any type in manual_typings/globals.d.ts #72

Closed
JamesHenry opened this issue Apr 27, 2016 · 4 comments
Closed

Implicit any type in manual_typings/globals.d.ts #72

JamesHenry opened this issue Apr 27, 2016 · 4 comments
Labels

Comments

@JamesHenry
Copy link
Member

Hey @Hotell,

I have enabled the noImplicitAny flag for the TS compiler for my code base and I am down to one last error... in ng-metadata :)

The culprit is expensiveChecks in manual_typings/globals.d.ts:

interface IParseService{
    ( exp: string, interceptorFn?: Function, expensiveChecks? ): ng.ICompiledExpression
  }

Are you happy to accept a PR to annotate it explicitly with : any?

@Hotell
Copy link
Member

Hotell commented Apr 27, 2016

Hey, of course!
Let's add there proper type, which is boolean.
High five! 👍

@JamesHenry
Copy link
Member Author

#73

@artaommahe
Copy link
Contributor

same problem with this part
https://github.com/ngParty/ng-metadata/blob/master/manual_typings/globals.d.ts#L89
all Watchers methods params without types, a lot of erros on build (

@Hotell
Copy link
Member

Hotell commented May 22, 2016

hmm, interesting, you're right, reopening, it must be related to my latest refactoring

for reference adding error log:

tsc

91     exp: ( s, l, a, i ) => any,
              ~

node_modules/ng-metadata/manual_typings/globals.d.ts(91,12): error TS7006: Parameter 's' implicitly has an 'any' type.


91     exp: ( s, l, a, i ) => any,
                 ~

node_modules/ng-metadata/manual_typings/globals.d.ts(91,15): error TS7006: Parameter 'l' implicitly has an 'any' type.


91     exp: ( s, l, a, i ) => any,
                    ~

node_modules/ng-metadata/manual_typings/globals.d.ts(91,18): error TS7006: Parameter 'a' implicitly has an 'any' type.


91     exp: ( s, l, a, i ) => any,
                       ~

node_modules/ng-metadata/manual_typings/globals.d.ts(91,21): error TS7006: Parameter 'i' implicitly has an 'any' type.


92     fn: ( newValue, oldValue ) => any,
             ~~~~~~~~

node_modules/ng-metadata/manual_typings/globals.d.ts(92,11): error TS7006: Parameter 'newValue' implicitly has an 'any' type.


92     fn: ( newValue, oldValue ) => any,
                       ~~~~~~~~

node_modules/ng-metadata/manual_typings/globals.d.ts(92,21): error TS7006: Parameter 'oldValue' implicitly has an 'any' type.


93     get: ( s, l, a, i ) => any,
              ~

node_modules/ng-metadata/manual_typings/globals.d.ts(93,12): error TS7006: Parameter 's' implicitly has an 'any' type.


93     get: ( s, l, a, i ) => any,
                 ~

node_modules/ng-metadata/manual_typings/globals.d.ts(93,15): error TS7006: Parameter 'l' implicitly has an 'any' type.


93     get: ( s, l, a, i ) => any,
                    ~

node_modules/ng-metadata/manual_typings/globals.d.ts(93,18): error TS7006: Parameter 'a' implicitly has an 'any' type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants