Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't allow newlines in interpreted_string_literal #26

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

guilhas07
Copy link
Contributor

@guilhas07 guilhas07 commented Jan 13, 2025

Problem:
interpreted_string_literal doesn't support multiline.
When trying to parse:

{{ "foo
"}}

Go fails with unterminated quoted string.

Solution:
Add token.immediate to the closing string delimiter.

@qvalentin
Copy link
Collaborator

Seems reasonable, but please shortly explain why the change is required.

Seems like templating would fail with the message "unterminated quoted string".

@guilhas07
Copy link
Contributor Author

Seems reasonable, but please shortly explain why the change is required.

Seems like templating would fail with the message "unterminated quoted string".

Updated PR description, and pushed with the helm build.

@qvalentin qvalentin merged commit 4fc529d into ngalaiko:master Jan 14, 2025
2 checks passed
@guilhas07 guilhas07 deleted the fix-strings branch January 14, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants