Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vars to populate preview url #173

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

nginx-jack
Copy link
Contributor

@nginx-jack nginx-jack commented Feb 7, 2025

Proposed changes

Use vars to populate preview url.
This will allow for forked versions of the repo to generate different preview urls without modifying the action file itself. (Mainly for internal use)

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

@nginx-jack nginx-jack requested a review from a team as a code owner February 7, 2025 10:13
Copy link

github-actions bot commented Feb 7, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/173/

@ADubhlaoich ADubhlaoich merged commit 0c62b77 into main Feb 12, 2025
8 checks passed
@ADubhlaoich ADubhlaoich deleted the configurable-preview-url branch February 12, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants