Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update PR links to GitHub URLs, fix inline Tutorial guidance #193

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

ADubhlaoich
Copy link
Contributor

Proposed changes

This commit updates the links from the PR templates to use the actual GitHub links: they are currently relative links that do not parse as intended, instead linking to parts of the GitHub website.

It also fixes an issue in the Tutorial archetype's inline Markdown guidance caused by an unintentionally escaped quotation mark.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

This commit updates the links from the PR templates to use the actual
GitHub links: they are currently relative links that do not parse as
intended, instead linking to parts of the GitHub website.

It also fixes an issue in the Tutorial archetype's inline Markdown
guidance caused by an unintentionally escaped quotation mark.
@ADubhlaoich ADubhlaoich requested review from a team as code owners February 12, 2025 16:01
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/193/

@ADubhlaoich ADubhlaoich merged commit f278718 into main Feb 13, 2025
4 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/fix-issue-links branch February 13, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant