Refactor upstream test name to include both OSS and Plus server count

nginx · Aug 23, 2024 · 957568f · 957568f
1 parent cb98e79
commit 957568f
Showing 1 changed file with 18 additions and 31 deletions.
diff --git a/tests/suite/scale_test.go b/tests/suite/scale_test.go
@@ -571,37 +571,24 @@ The logs are attached only if there are errors.
 			},
 		)
 	})
-	if upstreamServerCount == ossUpstreamServerCount {
-		It(fmt.Sprintf("scales upstream servers to %d", ossUpstreamServerCount), func() {
-			const testName = "TestScale_UpstreamServers"
-
-			testResultsDir := filepath.Join(resultsDir, testName)
-			Expect(os.MkdirAll(testResultsDir, 0o755)).To(Succeed())
-
-			runTestWithMetricsAndLogs(
-				testName,
-				testResultsDir,
-				func() {
-					runScaleUpstreams()
-				},
-			)
-		})
-	} else {
-		It(fmt.Sprintf("scales upstream servers to %d", plusUpstreamServerCount), func() {
-			const testName = "TestScale_UpstreamServers"
-
-			testResultsDir := filepath.Join(resultsDir, testName)
-			Expect(os.MkdirAll(testResultsDir, 0o755)).To(Succeed())
-
-			runTestWithMetricsAndLogs(
-				testName,
-				testResultsDir,
-				func() {
-					runScaleUpstreams()
-				},
-			)
-		})
-	}
+
+	It(fmt.Sprintf("scales upstream servers to %d for OSS and %d for Plus",
+		ossUpstreamServerCount,
+		plusUpstreamServerCount,
+	), func() {
+		const testName = "TestScale_UpstreamServers"
+
+		testResultsDir := filepath.Join(resultsDir, testName)
+		Expect(os.MkdirAll(testResultsDir, 0o755)).To(Succeed())
+
+		runTestWithMetricsAndLogs(
+			testName,
+			testResultsDir,
+			func() {
+				runScaleUpstreams()
+			},
+		)
+	})
 
 	It("scales HTTP matches", func() {
 		const testName = "TestScale_HTTPMatches"