Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable sending telemetry in tests #1705

Closed
pleshakov opened this issue Mar 18, 2024 · 0 comments
Closed

Disable sending telemetry in tests #1705

pleshakov opened this issue Mar 18, 2024 · 0 comments
Assignees
@pleshakov
Labels
area/telemetry Issues related to collected telemetry data size/small Estimated to be completed within ~2 days
Milestone
v1.2.0

Comments

@pleshakov
Copy link
Contributor

pleshakov commented Mar 18, 2024 •
edited by mpstefan
Loading

Disable telemetry in:

Note: enabled telemetry introduced in b6cb677
@mpstefan mpstefan added this to the v1.2.0 milestone Mar 18, 2024
@mpstefan mpstefan added area/telemetry Issues related to collected telemetry data size/small Estimated to be completed within ~2 days labels Mar 18, 2024
@pleshakov pleshakov self-assigned this Mar 18, 2024
pleshakov added a commit that referenced this issue Mar 18, 2024
@pleshakov
Disable sending telemetry in tests
e74505e 
Problem:

b6cb677 enabled product telemetry reporting.
However, the telemetry is also reported when running tests,
which we want to avoid, so that the gathered telemetry doesn't
include data from our test runs.

Solution:

Disable telemetry for:
- Conformance tests
- Helm chart
- NFR and functional tests

CLOSES - #1705

Testing:
- To be confirmed by the pipeline
- Ran telemetry functional test manually successfully.
- Ran NGR test successfully on GCP. No telemetry were reported,
  confirmed on the telemetry receiver side. (Note. Upgrade test
  failed with "Error: INSTALLATION FAILED: release name "": no name
  provided" error. However, this was not caused by this commit and
  out of scope of this commit)
@pleshakov pleshakov mentioned this issue Mar 18, 2024
Merged
6 tasks
pleshakov added a commit that referenced this issue Mar 18, 2024
@pleshakov
Disable sending telemetry in tests (#1714)
96a4424 
Problem:

b6cb677 enabled product telemetry reporting.
However, the telemetry is also reported when running tests,
which we want to avoid, so that the gathered telemetry doesn't
include data from our test runs.

Solution:

Disable telemetry for:
- Conformance tests
- Helm chart
- NFR and functional tests

CLOSES - #1705

Testing:
- To be confirmed by the pipeline
- Ran telemetry functional test manually successfully.
- Ran NGR test successfully on GCP. No telemetry were reported,
  confirmed on the telemetry receiver side. (Note. Upgrade test
  failed with "Error: INSTALLATION FAILED: release name "": no name
  provided" error. However, this was not caused by this commit and
  out of scope of this commit)
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this issue Apr 3, 2024
@pleshakov @amimimor
Disable sending telemetry in tests (nginx#1714)
7adc3e1 
Problem:

b6cb677 enabled product telemetry reporting.
However, the telemetry is also reported when running tests,
which we want to avoid, so that the gathered telemetry doesn't
include data from our test runs.

Solution:

Disable telemetry for:
- Conformance tests
- Helm chart
- NFR and functional tests

CLOSES - nginx#1705

Testing:
- To be confirmed by the pipeline
- Ran telemetry functional test manually successfully.
- Ran NGR test successfully on GCP. No telemetry were reported,
  confirmed on the telemetry receiver side. (Note. Upgrade test
  failed with "Error: INSTALLATION FAILED: release name "": no name
  provided" error. However, this was not caused by this commit and
  out of scope of this commit)
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this issue Jan 14, 2025
@miledxz
Disable sending telemetry in tests (nginx#1714)
246d96f 
Problem:

b6cb677 enabled product telemetry reporting.
However, the telemetry is also reported when running tests,
which we want to avoid, so that the gathered telemetry doesn't
include data from our test runs.

Solution:

Disable telemetry for:
- Conformance tests
- Helm chart
- NFR and functional tests

CLOSES - nginx#1705

Testing:
- To be confirmed by the pipeline
- Ran telemetry functional test manually successfully.
- Ran NGR test successfully on GCP. No telemetry were reported,
  confirmed on the telemetry receiver side. (Note. Upgrade test
  failed with "Error: INSTALLATION FAILED: release name "": no name
  provided" error. However, this was not caused by this commit and
  out of scope of this commit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pleshakov pleshakov

Labels
area/telemetry Issues related to collected telemetry data size/small Estimated to be completed within ~2 days
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
2 participants
@pleshakov @mpstefan