Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx-prometheus-exporter to 1.0.0 #1347

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 7, 2023

Bumps github.com/nginxinc/nginx-prometheus-exporter from 0.11.0 to 1.0.0.

Release notes

Sourced from github.com/nginxinc/nginx-prometheus-exporter's releases.

v1.0.0

What's Changed

💣 Breaking Changes

🚀 Features

🐛 Bug Fixes

🔨 Maintenance

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner December 7, 2023 00:14
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 7, 2023
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for nginx-gateway-fabric ready!

Name Link
🔨 Latest commit b2426f87d6a51ca72b905fd006a04a14227aae37
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/6579d4dbe5ae330008097012
😎 Deploy Preview https://deploy-preview-1347--nginx-gateway-fabric.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kate-osborn kate-osborn self-assigned this Dec 11, 2023
@kate-osborn
Copy link
Contributor

I'll take this over and fix the errors.

@kate-osborn kate-osborn force-pushed the dependabot/go_modules/github.com/nginxinc/nginx-prometheus-exporter-1.0.0 branch from 9d734e1 to 3a83f2a Compare December 11, 2023 21:23
@kate-osborn kate-osborn force-pushed the dependabot/go_modules/github.com/nginxinc/nginx-prometheus-exporter-1.0.0 branch from b2426f8 to 85e5b3e Compare December 15, 2023 17:32
@kate-osborn kate-osborn force-pushed the dependabot/go_modules/github.com/nginxinc/nginx-prometheus-exporter-1.0.0 branch from 85e5b3e to 029d65e Compare December 19, 2023 21:44
@kate-osborn kate-osborn force-pushed the dependabot/go_modules/github.com/nginxinc/nginx-prometheus-exporter-1.0.0 branch 2 times, most recently from 7d72119 to ef0508a Compare December 21, 2023 23:33
@kate-osborn kate-osborn changed the title Bump github.com/nginxinc/nginx-prometheus-exporter from 0.11.0 to 1.0.0 Update nginx-prometheus-exporter to 1.0.0 Dec 21, 2023
@kate-osborn kate-osborn requested a review from pleshakov January 2, 2024 18:19
internal/mode/static/config_updater.go Outdated Show resolved Hide resolved
internal/mode/static/config_updater.go Outdated Show resolved Hide resolved
internal/mode/static/config_updater.go Outdated Show resolved Hide resolved
internal/mode/static/metrics/collectors/nginx.go Outdated Show resolved Hide resolved
@kate-osborn kate-osborn added this to the v1.2.0 milestone Jan 3, 2024
@kate-osborn kate-osborn force-pushed the dependabot/go_modules/github.com/nginxinc/nginx-prometheus-exporter-1.0.0 branch from ef0508a to aca5f26 Compare January 4, 2024 22:13
dependabot bot and others added 6 commits January 8, 2024 11:19
Bumps [github.com/nginxinc/nginx-prometheus-exporter](https://github.com/nginxinc/nginx-prometheus-exporter) from 0.11.0 to 1.0.0.
- [Release notes](https://github.com/nginxinc/nginx-prometheus-exporter/releases)
- [Changelog](https://github.com/nginxinc/nginx-prometheus-exporter/blob/main/CHANGELOG.md)
- [Commits](nginx/nginx-prometheus-exporter@v0.11.0...v1.0.0)

---
updated-dependencies:
- dependency-name: github.com/nginxinc/nginx-prometheus-exporter
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@kate-osborn kate-osborn force-pushed the dependabot/go_modules/github.com/nginxinc/nginx-prometheus-exporter-1.0.0 branch from 1e39ad4 to 2023463 Compare January 8, 2024 18:19
@kate-osborn kate-osborn merged commit bf87eec into main Jan 8, 2024
27 checks passed
@kate-osborn kate-osborn deleted the dependabot/go_modules/github.com/nginxinc/nginx-prometheus-exporter-1.0.0 branch January 8, 2024 18:46
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Problem: The new version of the NGINX Prometheus Exporter
introduces a couple of breaking changes. One of these changes
is that the exporter now requires a logger to be passed to the 
collectors. This logger interface is incompatible with NGF's logger.

Solution: Update to version 1.0.0 of the NGINX Prometheus Exporter
and fix errors. Wraps the Prometheus exporter logger in an interface
so that we can control its log level alongside our base logger.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants