-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test automation: zero-downtime upgrades #1438
Conversation
a6aa7a2
to
992674a
Compare
@kate-osborn Unfortunately we don't have the tests set up yet to pull changes from local, so I have to test every change by pushing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
dee2d52
to
3ba62eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great. I run it a few times, both with cases when everything went well and with downtime (for that, I reduced the sleep values in the values file).
I left a few suggestion. And I think there is a bug with waiting for leader election to happen
Problem: Running system tests manually is a time consuming and arduous process, and can lead to inconsistent results. Solution: Add automation for the zero-downtime upgrades test. This test must be run on GKE. The test deploys the previous released version of NGF, then begins sending http and https traffic while performing an upgrade to NGF. Results are rendered and written. CSV files are getting too large to commit to the repository, so not including those going forward.
3ba62eb
to
31ce0dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Problem: Running system tests manually is a time consuming and arduous process, and can lead to inconsistent results. Solution: Add automation for the zero-downtime upgrades test. This test must be run on GKE. The test deploys the previous released version of NGF, then begins sending http and https traffic while performing an upgrade to NGF. Results are rendered and written. CSV files are getting too large to commit to the repository, so not including those going forward.
Problem: Running system tests manually is a time consuming and arduous process, and can lead to inconsistent results.
Solution: Add automation for the zero-downtime upgrades test. This test must be run on GKE. The test deploys the previous released version of NGF, then begins sending http and https traffic while performing an upgrade to NGF. Results are rendered and written.
CSV files are getting too large to commit to the repository, so not including those going forward.
Closes #1364