-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plus to test suites #1536
Add plus to test suites #1536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4577168
to
3d434d3
Compare
There appear to be 2 pending checks now, does the new matrix affect the job reporting? |
@sjberman yes, once this is merged I'll update the required checks in the repository settings. Annoyingly, the required checks are defined by job name, and adding a new element to the matrix changes these job names (e.g. |
3d434d3
to
a555152
Compare
@ciarams87 I wonder why this is a repo setting and not something that you can set in the pipeline itself... |
Proposed changes
Problem: As a user of NGF that uses an NGINX+ image of NGF
I want the NGINX+ image to be tested with Gateway API's conformance tests and NGINX's non-functional testing
So that I can feel confident that the NGINX+ version of NGF is just as stable as the OSS version.
Solution:
Testing: Ran the conformance tests and the NFR tests using Plus
Please focus on (optional): The AC includes "The release process is updated to include that non-functional tests must be ran against the NGINX+ image in addition to OSS." but we do not have any section in the release process that covers running the NFR tests (as they are currently covered as separate tasks)
Closes #1331
Checklist
Before creating a PR, run through this checklist and mark each as complete.