Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NGINX Bot to GitHub App #1618

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Move NGINX Bot to GitHub App #1618

merged 4 commits into from
Feb 28, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Feb 27, 2024

Proposed changes

Problem: Some operations are not possible from a GitHub Actions.

Solution: Make it into a GitHub App. This will also allow us to have many more functionalities in the future.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Problem: Some operations are not possible from a GitHub Actions.

Solution: Make it into a GitHub App. This will also allow us to have
many more functionalities in the future.
@lucacome lucacome requested a review from a team as a code owner February 27, 2024 00:11
@nginx-bot nginx-bot bot added the community label Feb 27, 2024
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 27, 2024
@nginx nginx deleted a comment from nginx-bot bot Feb 27, 2024
@lucacome lucacome enabled auto-merge (squash) February 28, 2024 19:21
@lucacome lucacome merged commit ad80b76 into nginx:main Feb 28, 2024
33 checks passed
@lucacome lucacome deleted the chore/nginx-bot branch April 1, 2024 23:24
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Problem: Some operations are not possible from a GitHub Actions.

Solution: Make it into a GitHub App. This will also allow us to have
many more functionalities in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants