Add NGF build information to test results #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: We don't add the commit that was tested to the test results and we don't have a way to confirm that the correct version was tested. Solution: Add build info to the tests results
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2353 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 97 97
Lines 6996 6996
Branches 50 50
=======================================
Hits 6162 6162
Misses 777 777
Partials 57 57 ☔ View full report in Codecov by Sentry. |
sjberman
approved these changes
Aug 8, 2024
bjee19
requested changes
Aug 8, 2024
bjee19
approved these changes
Aug 8, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: We don't add the commit that was tested to the test results and we don't have a way to confirm that the correct version was tested. Solution: Add build info to the tests results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We don't add the commit that was tested to the test results and we don't have a way to confirm that the correct version was tested.
Solution: Add build info to the tests results
Closes #2321
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.