Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more linters #2545

Merged
merged 10 commits into from
Sep 17, 2024
Merged

Enable more linters #2545

merged 10 commits into from
Sep 17, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Enables more linters that check for bugs in the code.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner September 12, 2024 19:00
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests labels Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.29%. Comparing base (f74d70a) to head (2c91174).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/mode/static/manager.go 0.00% 8 Missing ⚠️
internal/mode/provisioner/manager.go 0.00% 1 Missing ⚠️
internal/mode/static/status/prepare_requests.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2545      +/-   ##
==========================================
- Coverage   89.34%   89.29%   -0.05%     
==========================================
  Files         100      100              
  Lines        7630     7633       +3     
  Branches       50       50              
==========================================
- Hits         6817     6816       -1     
- Misses        756      761       +5     
+ Partials       57       56       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/mode/static/manager.go Show resolved Hide resolved
internal/mode/static/manager.go Outdated Show resolved Hide resolved
internal/mode/static/state/graph/backend_refs.go Outdated Show resolved Hide resolved
@lucacome lucacome enabled auto-merge (squash) September 12, 2024 20:57
@lucacome lucacome requested a review from a team September 16, 2024 20:47
@lucacome lucacome self-assigned this Sep 17, 2024
@lucacome lucacome merged commit a432151 into nginx:main Sep 17, 2024
37 of 38 checks passed
@lucacome lucacome deleted the chore/lint branch September 17, 2024 18:50
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants