-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loadBalancerSourceRanges to helm parameters #2773
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2773 +/- ##
=======================================
Coverage 89.40% 89.40%
=======================================
Files 110 110
Lines 10913 10913
Branches 50 50
=======================================
Hits 9757 9757
Misses 1098 1098
Partials 58 58 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to link the issue in the PR description.
8a16bdb
to
12bf5f1
Compare
12bf5f1
to
c89255b
Compare
Add loadBalancerSourceRanges to helm parameters Problem: Users need a way to provide the loadBalancerSourceRanges to restrict IPs that can access the load balancer. Solution: Added a helm parameter to specify loadBalancerSourceRanges during helm install/upgrade
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users need a way to provide the
loadBalancerSourceRanges
to restrict IPs that can access the load balancer.Solution: Added a helm parameter to specify
loadBalancerSourceRanges
during helm install/upgradeTesting: Manual testing by adding
loadBalancerSourceRanges
in values.yaml file and doing a helm install. Verified the service specifications for changes to be reflected correctly.Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #1865
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.