Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove announce for slack (#3104) #3105

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Remove announce for slack (#3104) #3105

merged 1 commit into from
Feb 7, 2025

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Feb 6, 2025

(cherry picked from commit 01da5c7)

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

(cherry picked from commit 01da5c7)
@lucacome lucacome requested a review from a team as a code owner February 6, 2025 23:51
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 6, 2025
@lucacome lucacome enabled auto-merge (squash) February 6, 2025 23:51
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.95%. Comparing base (999cded) to head (832116f).
Report is 1 commits behind head on release-1.6.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.6    #3105   +/-   ##
============================================
  Coverage        89.95%   89.95%           
============================================
  Files              111      111           
  Lines            11453    11453           
  Branches            50       50           
============================================
  Hits             10303    10303           
  Misses            1089     1089           
  Partials            61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome merged commit 14e71d7 into release-1.6 Feb 7, 2025
40 checks passed
@lucacome lucacome deleted the chore/slack branch February 7, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants