Set Gateway Programmed condition #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
pleshakov
suggested changes
May 23, 2023
sjberman
force-pushed
the
feature/gateway-programmed
branch
2 times, most recently
from
c69c9c5 to
cd55e13
Compare
kate-osborn
suggested changes
May 23, 2023
pleshakov
reviewed
May 25, 2023
6 tasks
sjberman
force-pushed
the
feature/gateway-programmed
branch
from
cd55e13 to
39d838a
Compare
sjberman
commented
May 25, 2023
sjberman
force-pushed
the
feature/gateway-programmed
branch
from
39d838a to
f45a282
Compare
kate-osborn
suggested changes
May 25, 2023
sjberman
force-pushed
the
feature/gateway-programmed
branch
2 times, most recently
from
1ac45a2 to
edcf46c
Compare
pleshakov
reviewed
May 30, 2023
sjberman
force-pushed
the
feature/gateway-programmed
branch
from
e74c66a to
5ef9689
Compare
kate-osborn
reviewed
Jun 1, 2023
When the Gateway configuration has been successfully uploaded to nginx, we will set the status Programmed to true. If there's any error with updating nginx, then we set Programmed to false. We'll also set a negative status on the HTTPRoutes in the system to explain that the Gateway is not programmed. Moved the buildStatuses logic into the status package and removed redundant tests.
sjberman
force-pushed
the
feature/gateway-programmed
branch
from
5ef9689 to
85657cc
Compare
kate-osborn
approved these changes
Jun 1, 2023
pleshakov
reviewed
Jun 1, 2023
pleshakov
approved these changes
Jun 1, 2023
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
* Set Gateway Programmed condition When the Gateway configuration has been successfully uploaded to nginx, we will set the status Programmed to true. If there's any error with updating nginx, then we set Programmed to false. We'll also set a negative status on the HTTPRoutes in the system to explain that the Gateway is not programmed. Moved the buildStatuses logic into the status package and removed redundant tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Gateway configuration has been successfully uploaded to nginx, we will set the status Programmed to true. If there's any error with updating nginx, then we set Programmed to false. We'll also set a negative status on the HTTPRoutes in the system to explain that the Gateway is not programmed.
Closes #610