-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go style guide #679
Merged
Merged
Add Go style guide #679
+489
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarams87
reviewed
May 25, 2023
sjberman
requested changes
May 25, 2023
sjberman
approved these changes
May 25, 2023
ciarams87
approved these changes
May 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
pleshakov
reviewed
May 30, 2023
Co-authored-by: Ciara Stacke <[email protected]>
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: Saylor Berman <[email protected]>
Co-authored-by: Michael Pleshakov <[email protected]>
4e6c451
to
8afdf89
Compare
pleshakov
approved these changes
May 30, 2023
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: The project's coding style guidelines are undocumented. Solution: Add a Go style guide to the developer docs and link to it in the developer guide and the implementing a feature guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a style guide for Go. Once #669 is merged, I will add a link to this doc in CONTRIBUTING.md.
Closes #671
Checklist
Before creating a PR, run through this checklist and mark each as complete.